Skip to content
Snippets Groups Projects
  1. Jan 21, 2022
  2. Sep 10, 2019
    • Nora Tarano's avatar
      [breaking][deps] Update all dependencies · 48b523d0
      Nora Tarano authored
      - Drop support for node < 6
      - Update: @storybook, webpack, react-with-styles, react-with-direction,
        react-with-styles-interface-aphrodite,
        react-with-styles-interface-css,
        react-with-styles-interface-css-compiler
      48b523d0
  3. Jun 05, 2019
    • Henric Trotzig's avatar
      Avoid unnecessary spread · fcdeeb46
      Henric Trotzig authored
      We can just push multiple objects into the array in one go.
      fcdeeb46
    • Henric Trotzig's avatar
      Update to Storybook v5 · b6295428
      Henric Trotzig authored
      I was running into issues making a static Storybook build on v4 of
      Storybook (see https://github.com/airbnb/react-dates/pull/1382#issuecomment-498856007).
      
      The error I'm seeing is something like
      
      ERR! ./examples/DateRangePickerWrapper.jsx
      ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js):
      ERR! TypeError: Property declarations[0] of VariableDeclaration expected node to be of a type ["VariableDeclarator"] but instead got "ExpressionStatement"
      ERR!     at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:128:13)
      ERR!     at validator (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:97:7)
      ERR!     at Object.validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/definitions/utils.js:172:7)
      ERR!     at validate (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/validators/validate.js:17:9)
      ERR!     at builder (/home/travis/build/airbnb/react-dates/node_modules/@babel/types/lib/builders/builder.js:46:27)
      ERR!     at Object.VariableDeclaration (/home/travis/build/airbnb/react-
      
      It seems to happen at the minification step, because right before that
      error happens I'm seeing "92% chunk asset TerserPlugin".
      
      I started going down the route of tracing this down in Storybook v4, but
      then decided to give v5 a spin instead. It turns out the upgrade isn't
      all that complicated, and it does resolve the error I was seeing.
      
      The only change needed except for bumping all the @storybook
      dependencies was to turn the webpack config from "extend mode" to "full
      control mode". See https://storybook.js.org/docs/configurations/custom-webpack-config/
      
      I used this guide as a starting point to the upgrade:
      https://medium.com/storybookjs/storybook-5-migration-guide-d804b38c739d
      b6295428
  4. Sep 13, 2018
  5. Sep 05, 2018
  6. Aug 30, 2018
  7. Nov 28, 2017
  8. Nov 09, 2017
  9. Oct 06, 2017
  10. Jun 29, 2017
  11. Jun 28, 2017
  12. Mar 30, 2017
  13. Mar 22, 2017
  14. Feb 22, 2017
  15. Feb 17, 2017
  16. Nov 22, 2016
  17. Aug 17, 2016
Loading